Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize directory names for model download #10

Open
Nelson-Gon opened this issue Dec 12, 2023 · 1 comment
Open

Randomize directory names for model download #10

Nelson-Gon opened this issue Dec 12, 2023 · 1 comment
Labels

Comments

@Nelson-Gon
Copy link
Owner

Currently, we are using the following

hifi_gan = HIFIGAN.from_hparams(source=self.hifigan_source, savedir="tmpdir_vocoder")
tacotron2 = Tacotron2.from_hparams(source=self.tacotron_source, savedir="tmpdir_tts")

This is problematic because it will always attempt to either download models or load them from that specific folder which will sometimes fail with no obvious reason as to why it has failed.

This issue proposes using a randomized directory name as the save directory. A better approach might be to use some sort of caching to cache the models. This is related to #8

@Nelson-Gon
Copy link
Owner Author

This is likely obsolete but leaving it here as I figure out what to do with TTS GANs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant