Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases where output does not end with the end of line identifier (\n) #9

Open
3 tasks
Nelson-Gon opened this issue Dec 11, 2023 · 3 comments
Open
3 tasks
Assignees
Labels
bug Something isn't working good first issue Good for newcomers priority:high text-generation

Comments

@Nelson-Gon
Copy link
Owner

Currently we assume that the response will always end in \n in which case we can split it. This will fail if the assumption does not hold for example in cases where only a single line is produced with no EOL identifier.

Possible solutions

  • Check for lengths of return values
  • Check for existence of EOL identifier
  • Use some sort of regex match to determine if a split is needed
@Nelson-Gon Nelson-Gon added bug Something isn't working good first issue Good for newcomers text-generation priority:high labels Dec 11, 2023
@NoobProgrammer31
Copy link

why is fork option not available?

@NoobProgrammer31
Copy link

assign me this

@Nelson-Gon
Copy link
Owner Author

assign me this

Assigned to you, thanks

why is fork option not available?

It should be available

Nelson-Gon added a commit that referenced this issue Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority:high text-generation
Projects
None yet
Development

No branches or pull requests

2 participants