Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a custom transport when instantiating clients #197

Open
lawrencejones opened this issue May 15, 2023 · 2 comments 路 May be fixed by #263
Open

Allow setting a custom transport when instantiating clients #197

lawrencejones opened this issue May 15, 2023 · 2 comments 路 May be fixed by #263
Labels
question Further information is requested

Comments

@lawrencejones
Copy link

Hey 馃憢

I might be missing it, but I can't see any way to provide a custom http transport to the client.

For people building integrations inside larger applications, it's normal to provide a custom transport to provide standardised logging/tracing/retrying into their third-party clients.

Would you consider adding another client.Option that supports configuring a base transport?

Thanks!

@rocktavious
Copy link
Collaborator

Hey @lawrencejones - I would be open to this but I think that area of code to provide this is going to need a major refactor/cleanup so it might be a heavy lift. If you are willing to work on this refactor i'm open to reviewing and testing out your solution. Our team currently is a bit too small and behind on product features so we won't beable to take this on within our Q2 roadmap so it would have to wait to be scheduled for Q3. Let me know what you think. Thanks!

@rocktavious rocktavious added the question Further information is requested label Jul 17, 2023
@zakisk zakisk linked a pull request Oct 3, 2023 that will close this issue
1 task
@zakisk
Copy link

zakisk commented Oct 3, 2023

@rocktavious @lawrencejones is the ideal solution for this problem, please review #263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants