Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_SparseGPRegression_rbf_white_kern_1d test failure on powerpc64le arch #1054

Open
Apteryks opened this issue Dec 19, 2023 · 4 comments
Open
Labels
need more info If an issue or PR needs further information by the issuer

Comments

@Apteryks
Copy link

Hello,

Found by GNU Guix CI (https://ci.guix.gnu.org/build/2921270/)

[...]
test_SparseGPRegression_rbf_white_kern_1d (GPy.testing.model_tests.GradientTests)
Testing the sparse GP regression with rbf kernel with white kernel on 1d data ... initializing Y
initializing inference method
adding kernel and likelihood as parameters
Adding Z as parameter
FAIL
[...]

======================================================================
FAIL: test_SparseGPRegression_rbf_white_kern_1d (GPy.testing.model_tests.GradientTests)
Testing the sparse GP regression with rbf kernel with white kernel on 1d data
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-python-gpy-1.10.0.drv-0/GPy-1.10.0/GPy/testing/model_tests.py", line 788, in test_SparseGPRegression_rbf_white_kern_1d
    self.check_model(rbf, model_type='SparseGPRegression', dimension=1)
  File "/tmp/guix-build-python-gpy-1.10.0.drv-0/GPy-1.10.0/GPy/testing/model_tests.py", line 682, in check_model
    self.assertTrue(m.checkgrad())
AssertionError: False is not true

----------------------------------------------------------------------
Ran 274 tests in 466.921s

FAILED (failures=1, skipped=3)

Thanks!

@MartinBubel
Copy link
Contributor

Hi @Apteryks
could you please retry using GPy==1.13.1? Tests have been migrated from nose to pytest and some things have changed.

@MartinBubel MartinBubel added the need more info If an issue or PR needs further information by the issuer label Jan 16, 2024
@Apteryks
Copy link
Author

Hi! I just tried updating GPy to version 1.13.1, and I'm getting a syntax error in the mpi_test__.py file which seemingly uses Python 2 syntax:

testing/mpi_test__.py'...
***   File "/gnu/store/7gyd40a2zchj2j1s796v5393laxpvr9l-python-gpy-1.13.1/lib/python3.10/site-packages/GPy/testing/mpi_test__.py", line 16
    print float(m.objective_function())
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?

Any tip?

@MartinBubel
Copy link
Contributor

Clearly, this is a something I overlooked when modernizing the tests.
I am a little confused why CI testing did not run into this 🤔 but anyways, thanks for reporting! I'll open up a branch on this one.

@MartinBubel
Copy link
Contributor

@Apteryks I am not sure how you are running the tests. Is there any way you can test if branch 1054-test_sparsegpregression_rbf_white_kern_1d-test-failure-on-powerpc64le-arch fixes this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need more info If an issue or PR needs further information by the issuer
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants