Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Header - nav tags need to have unique names #159

Open
LukeTaylor34 opened this issue Feb 7, 2024 · 1 comment
Open

[BUG] Header - nav tags need to have unique names #159

LukeTaylor34 opened this issue Feb 7, 2024 · 1 comment
Labels
accessibility bug Something isn't working

Comments

@LukeTaylor34
Copy link

Describe the bug
The header fails axe auto accessibility test for having navigation landmarks with no unique name. Landmarks must have a unique aria-label, aria-labelledby to make landmarks distinguishable and identify purpose.

Expected behaviour
Any landmarks that are repeated must have a unique name that clearly describes it purpose.

My thoughts are the header menu items could be in a nav with an accessible name of site navigation and the admiralty-header-profile could have the name profile.

Although the 'nav' is intended only for a major block of navigation links not for singular links so when the user has yet to sign in the Sign In link does not need to be in a 'nav' or would need a different unique name to the suggestion above for the admiralty-header-profile element.

Also I don't think the Admiralty logo link should be in the same nav as the header menu items as it may have a different purpose.

Screenshots
image

@LukeTaylor34 LukeTaylor34 added bug Something isn't working accessibility labels Feb 7, 2024
@KatiePUX
Copy link
Collaborator

Tickets 114, 157, 178, 149 linked - let team Kai know when you are working on these so they can make adjustments when required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants