Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spin support percent #48657

Open
wants to merge 22 commits into
base: feature
Choose a base branch
from
Open

feat: Spin support percent #48657

wants to merge 22 commits into from

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 26, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

ref #48647

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Spin support percent to render as progress.
🇨🇳 Chinese Spin 支持 percent属性以进度形态展示。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 26, 2024

👁 Visual Regression Report for PR #48657 Failed ❌

🎯 Target branch: feature (ab7ac62)
📖 View Full Report ↗︎

Expected (Branch feature) Actual (Current PR) Diff
progress-info-position.compact.png progress-info-position.compact.png progress-info-position.compact.css-var.png progress-info-position.compact.css-var.png
progress-info-position.dark.png progress-info-position.dark.png progress-info-position.dark.css-var.png progress-info-position.dark.css-var.png
progress-info-position.default.png progress-info-position.default.png progress-info-position.default.css-var.png progress-info-position.default.css-var.png

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Apr 26, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 339.48 KB (+470 B 🔺)
./dist/antd-with-locales.min.js 387.19 KB (+334 B 🔺)

Copy link

codesandbox-ci bot commented Apr 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@zombieJ zombieJ changed the title [WIP] Preview only. Do not merge!!! feat: Spin support percent May 16, 2024
@zombieJ zombieJ marked this pull request as ready for review May 16, 2024 11:27
@afc163
Copy link
Member

afc163 commented May 20, 2024

感觉可以搞一个 nprogress 模式了

yoyo837
yoyo837 previously approved these changes May 31, 2024
crazyair
crazyair previously approved these changes May 31, 2024
@zombieJ zombieJ dismissed stale reviews from crazyair and yoyo837 via 30d3be1 May 31, 2024 06:19
crazyair
crazyair previously approved these changes May 31, 2024
li-jia-nan
li-jia-nan previously approved these changes May 31, 2024
@zombieJ zombieJ dismissed stale reviews from li-jia-nan and crazyair via 8220e1d May 31, 2024 10:32
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 85.24590% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 99.93%. Comparing base (38050d6) to head (8220e1d).
Report is 3 commits behind head on feature.

Files Patch % Lines
components/spin/usePercent.ts 55.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           feature   #48657      +/-   ##
===========================================
- Coverage   100.00%   99.93%   -0.07%     
===========================================
  Files          745      749       +4     
  Lines        13007    13075      +68     
  Branches      3420     3429       +9     
===========================================
+ Hits         13007    13066      +59     
- Misses           0        9       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Jun 1, 2024

覆盖率掉了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants