Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar.Group 增加自定义maxPopoverContent #48950

Closed
coulis1018 opened this issue May 16, 2024 · 6 comments
Closed

Avatar.Group 增加自定义maxPopoverContent #48950

coulis1018 opened this issue May 16, 2024 · 6 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. improvement improve some features

Comments

@coulis1018
Copy link

What problem does this feature solve?

使用Avatar.Group 的maxCount 时,期望触发多余头像气泡弹出时,可以增加自定义popover 的content ,以便展示出更丰富的内容信息。

What does the proposed API look like?

maxPopoverContent:ReactNode

@zombieJ zombieJ added improvement improve some features and removed unconfirmed labels May 22, 2024
@afc163
Copy link
Member

afc163 commented May 24, 2024

<Avatar.Group
  max={{
    count: 5,
    style: { ... },
    popover: { ... }, // Popover props
  }}
>

We should add a new prop max.

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label May 24, 2024
Copy link
Contributor

Hello @coulis1018. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @coulis1018,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@wanpan11
Copy link
Contributor

Let me give it a try

@beautiful-boyyy
Copy link

beautiful-boyyy commented May 27, 2024

请教一下测试popover属性的时候是把popover组件的测试copy一份过来吗,还是说有什么简便方法?

@wanpan11
Copy link
Contributor

请教一下测试popover属性的时候是把popover组件的测试copy一份过来吗,还是说有什么简便方法?

一般测试 UI存不存在就行了,实在是测属性 可以用 jest.mock (项目里可以找到栗子)

@afc163
Copy link
Member

afc163 commented Jun 1, 2024

#49131

@afc163 afc163 closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. improvement improve some features
Projects
None yet
Development

No branches or pull requests

5 participants