Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing type annotations #252

Open
CoolCat467 opened this issue Jan 17, 2024 · 5 comments
Open

Missing type annotations #252

CoolCat467 opened this issue Jan 17, 2024 · 5 comments

Comments

@CoolCat467
Copy link

While using this project in a project of my own, when type checking my project I found that there are no type annotations for this project and therefore the type checker I am using reports that it's unable to give accurate results because this project is untyped.

I would potentially be willing to work on adding type annotations, but in the past with other projects they've said that it would be better to make an issue about it first and see if it would be worth doing instead of putting the work in to make a pull request and not have it merged.

@c0fec0de
Copy link
Owner

Contribution is welcome.

Yeah, fill a pull request

@CoolCat467
Copy link
Author

First batch, adding type annotations for nodes: #253

@dzmitry-lahoda
Copy link

Also https://realpython.com/python312-typing/ removes some types boilerplate .

@CoolCat467 if you accept cryptodonations in anything (like USDC/USDT/whatever), not big, just share you wallet.

@dzmitry-lahoda
Copy link

dzmitry-lahoda commented Feb 14, 2024

@c0fec0de may you add CI to run on #253? that is by either invite of @CoolCat467 to project or modifying CI job/project settings.

@c0fec0de
Copy link
Owner

c0fec0de commented Feb 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants