Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest yosys: ast process_format_str() changed, plugin won't compile. #542

Open
hzeller opened this issue Aug 31, 2023 · 4 comments
Open

Comments

@hzeller
Copy link
Collaborator

hzeller commented Aug 31, 2023

Looks like the new function is now called processFormat(). So the systemverilog plug--in will not compile with latest yosys from head as our local copy of simplify.cc uses that in two places. So probably some #ifdef of sorts needed to work with older and newer yosys-es.

@wsipak
Copy link
Collaborator

wsipak commented Sep 1, 2023

Thank you. We'll look into the details. Indeed it looks like #ifdefs are the way to go here.

@hzeller
Copy link
Collaborator Author

hzeller commented Sep 12, 2023

I'll create a duplicate in the new location.

@tcal-x
Copy link

tcal-x commented Dec 12, 2023

Perhaps related to this, the latest plugins package doesn't work with the latest Yosys package (conda / litex-hub). We get a runtime error with the xdc and params plugins:

% plugin -i params
ERROR: Can't load module `./params': /home/tim/CFU-Playground/env/conda/envs/cfu-symbiflow/bin/../share/yosys/plugins/params.so: undefined symbol: _ZN5Yosys7stringfB5cxx11EPKcz
Yosys command produced an error
% plugin -i xdc
ERROR: Can't load module `./xdc': /home/tim/CFU-Playground/env/conda/envs/cfu-symbiflow/bin/../share/yosys/plugins/xdc.so: undefined symbol: _ZN5Yosys7stringfB5cxx11EPKcz
Yosys command produced an error

If I pin Yosys back at 0.33, it works (the latest is 0.36). I haven't determined precisely where this issue comes up.

Edit: I've found exactly where this issue comes up -- the jump to 0.34:
Using litex-hub::yosys=0.33_11_g31ee566ec=20230724_080446_py37 works as before
Using litex-hub::yosys=0.34_54_gd21c464ae=20230724_080446_py37 results in the undefined symbol error

@hzeller
Copy link
Collaborator Author

hzeller commented Dec 12, 2023

Yep, this should work in the new synlig plugin. Don't know who is maintaining the litex hub currently.

On NixOS/nix package manager, I have a relatively recent synlig and surelog if that helps

nix-shell -p surelog yosys yosys-synlig

surelog --version
VERSION: 1.80

yosys --version
Yosys 0.36 (git sha1 8f07a0d8404, gcc 12.3.0 -fPIC -Os)

yosys -p "plugin -i systemverilog; read_systemverilog foo.sv"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants