Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof PHASE_TABLE_MAINTENANCE #620 #832

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

taismassaro
Copy link

Fixed typos, mainly with punctuation, and attempted to fix some spacing issues I was able to identify, but was unclear on what to do when comments had an extra space at the beginning. I've seen in some places in the transcript they had an extra tab indentation, so I tried to follow that, but happy to adjust if they should be single spaces.

@@ -82,24 +82,30 @@ DSPMMJOB EQUALS DSPMMJB

# Page 1295
# PHASCHNG IS THE MAIN WAY OF MAKING PHASE CHANGES FOR RESTARTS. THERE ARE THREE FORMS OF PHASCHNG, KNOWN AS TYPE
# A, TYPE B, AND TYPE C. THEY ARE ALL CALLED AS FOLLOWS, WHERE OCT XXXXX CONTAINS THE PHASE INFORMATION,
# A, TYPE B, AND TYPE C. THEY ARE ALL CALLED AS FOLLOWS, WHERE OCT XXXXX CONTAINS THE PHASE INFORMATION,
#
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also unclear about when to add an empty comment line or just an empty line with no comment symbol.

@github-actions github-actions bot added the Type: Proof Comanche55 and Luminary99 files label Oct 18, 2021
@wopian wopian self-assigned this Oct 19, 2021
@wopian wopian self-requested a review October 19, 2021 11:35
@wopian wopian added this to the Luminary099 milestone Oct 19, 2021
@wopian wopian linked an issue Oct 19, 2021 that may be closed by this pull request
@taismassaro
Copy link
Author

hey @wopian, would you mind adding hacktoberfest-accepted so this PR counts as a hacktoberfest contribution? :)

@taismassaro
Copy link
Author

hey @wopian and @n4oah
any particular reason why this has been approved since last year, but not yet merged?

@wopian
Copy link
Collaborator

wopian commented Nov 3, 2022

n4oah is not a maintainer so I have no way of trusting their review and I've unfortunately just haven't had the free time to review the multitude of proofing PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proof PHASE_TABLE_MAINTENANCE
3 participants