Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof SERVICER.agc #636 #698

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

KouroshSimpkins
Copy link

Checked pages 857 to 864 Inclusive, and will be continuing on SERVICER.agc.

Update of pages 857-862 (exclusive) of SERVICER.agc
Continue to Page 865, currently finished page 864.
@github-actions github-actions bot added the Type: Proof Comanche55 and Luminary99 files label Sep 7, 2020
@wopian wopian linked an issue Sep 7, 2020 that may be closed by this pull request
@wopian wopian added this to the Luminary099 milestone Sep 7, 2020
@wopian wopian self-assigned this Sep 7, 2020
Pages 865 through 870, although unsure about how to handle the newlines in the comment block on page 869, as well as when there is a "+x" in the righmost column, how should they be indented?
@wopian
Copy link
Collaborator

wopian commented Oct 4, 2020

Hey @KouroshSimpkins, I didn't see the questions asked in the commit description at the time.

although unsure about how to handle the newlines in the comment block on page 869

Consecutive line breaks without a line number should be a maximum of 2 line breaks. https://github.com/chrislgarry/Apollo-11/blob/master/CONTRIBUTING.md#line-breaks

In the case of R0383 and the surrounding line breaks, that would be:

  • [tab]EXIT IS VIA Q.
  • 2 empty lines above R0383
  • R0383 itself as an empty line
  • 1 empty line below R0383
  • INPUT

as well as when there is a "+x" in the righmost column, how should they be indented?

Those should be [tab]+x[tab]INSTRUCTION. Ensure you're using tab formatting in your editor and have tab width set to 8 https://github.com/chrislgarry/Apollo-11/blob/master/CONTRIBUTING.md#formatting

image

Updated Parts of SERVICER to reflect the assistance provided with reference to large comment block on page 869 and +n in margins. Will continue to move through this (hopefully at about a page per day, maybe faster.) But have exams atm so will be a little slow. -KS
@KouroshSimpkins
Copy link
Author

Hi there @wopian, that's my bad I should've probably asked them as a comment in this PR, obviously I forgot because it was an update after I'd opened the PR.

Thanks for clearing up those questions I had though, I did think the empty lines would stack, but wasn't sure. I've implemented the changes to reflect your responses. I'll continue to update this PR as I move through SERVICER.agc, and I'll copy my commit descriptions into comments if it makes things easier?

@KouroshSimpkins
Update SERVICER.agc … d6168d9
Updated Parts of SERVICER to reflect the assistance provided with reference to large comment block on page 869 and +n in margins. Will continue to move through this (hopefully at about a page per day, maybe faster.) But have exams at the moment so will be a little slow. -KS

More updates soon
-KS

@wopian
Copy link
Collaborator

wopian commented Oct 7, 2020

I'll continue to update this PR as I move through SERVICER.agc, and I'll copy my commit descriptions into comments if it makes things easier?

If you need a question answered it'd be best to copy it as a comment that mentions me (I'll see it much quicker among my other notifications) otherwise the commit descriptions are fine 👍

Feel free to go at your own pace - it's a lot of pages to go through. I've converted the PR to a draft - I believe you'll be able to toggle your own PR by clicking "Ready for review" at the bottom when you've finished.

@wopian wopian marked this pull request as draft October 7, 2020 01:29
Finished checking Page 874
Finished proofing Page 875
@chrislgarry
Copy link
Owner

@KouroshSimpkins is this still in draft?

@KouroshSimpkins
Copy link
Author

@chrislgarry unfortunately yes, I'm about 65-70% done though.

I just want to go back and have a cursory second look at what I've done just to make sure it's not foolish.
-KS
@KouroshSimpkins KouroshSimpkins marked this pull request as ready for review January 6, 2021 11:48
@KouroshSimpkins
Copy link
Author

Okay I'm now happy with what I've done in this proofing, fixed everything that I could find. Hopefully it all looks good!

@wopian
Copy link
Collaborator

wopian commented Jan 6, 2021

Thank you @KouroshSimpkins.

I took December off from Open Source development and will be back reviewing the other PRs I was unable to get through in October/November and yours this month onwards 👍

@wopian wopian self-requested a review January 6, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed Type: Proof Comanche55 and Luminary99 files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proof SERVICER
3 participants