Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof SPS_BACK-UP_RCS_CONTROL #639 #675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Proof SPS_BACK-UP_RCS_CONTROL #639 #675

wants to merge 1 commit into from

Conversation

zbigos
Copy link

@zbigos zbigos commented Jun 10, 2020

I've proof read the entirety of the scans for the code.
I've attached .jpg files I've used for tracking the proofreading process, with some notes regarding fragments I wasn't sure about. If somebody could look at these and explain how they should be handled I'd be gratefull.
1510
1509
1508
1507

@wopian wopian added the Type: Proof Comanche55 and Luminary99 files label Jun 10, 2020
@wopian wopian added this to the Luminary099 milestone Jun 10, 2020
@wopian
Copy link
Collaborator

wopian commented Jun 10, 2020 •
edited

Lines beginning with R (i.e R0007) are comments and these won't have the extra 7 columns beside the assembly code. Ignore the 7 columns entirely as they're irrelevant to us.

image

The asterisk is in another column (although I'm not sure what its significance is). This is providing an example of the INHINT subroutine.

  • Column 1 is the subroutine (INHINT)
  • Column 2 is the function call (TC/CADR)
  • Column 3 is the value passed to the function call (multiple values are comma separated)

image

TC	Q

image

Keep the comment whitespace exactly as it is in the scans. In this case its ensuring the 2 sentences line up for GREATER THAN... and LESS THAN...

CORRECT:
IF JETS ARE FIRING POSITIVELY AND RATE IS   LESS  THAN TARGET RATE, LEAVE

INCORRECT:
IF JETS ARE FIRING POSITIVELY AND RATE IS LESS THAN TARGET RATE, LEAVE

image

The line should be wrapped with a broken POSITIVE as it does in the scans.

@wopian wopian linked an issue Jun 10, 2020 that may be closed by this pull request
Proof SPS_BACK-UP_RCS_CONTROL #639
Open
@wopian wopian self-requested a review October 13, 2020 01:08
@chrislgarry
Copy link
Owner

@zbigos want to give it another go? Just the few small fixes @wopian mentioned!

@KanegaeGabriel KanegaeGabriel mentioned this pull request Oct 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wopian wopian Awaiting requested review from wopian

Assignees

@wopian wopian

@zbigos zbigos

Labels
Status: Review Needed Type: Proof Comanche55 and Luminary99 files
Projects
None yet
Milestone
Luminary099
Development

Successfully merging this pull request may close these issues.

Proof SPS_BACK-UP_RCS_CONTROL
3 participants
@zbigos @wopian @chrislgarry