Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof PHASE_TABLE_MAINTENANCE #620

Open
wopian opened this issue Feb 20, 2020 · 9 comments · May be fixed by #832
Open

Proof PHASE_TABLE_MAINTENANCE #620

wopian opened this issue Feb 20, 2020 · 9 comments · May be fixed by #832
Assignees
@taismassaro
Labels
Good First Issue Help Wanted Size: Small 250 to 499 lines
Milestone
Luminary099

Comments

@wopian
Copy link
Collaborator

wopian commented Feb 20, 2020 •
edited

Proof read transcribed code of PHASE_TABLE_MAINTENANCE against scans

Lines: 411
Page: 1294—1302 (8)

Reduced quality scans can be found here
@wopian wopian added this to the Luminary099 milestone Feb 20, 2020
@wopian wopian added Size: Small 250 to 499 lines and removed Size: Moderate 500 to 749 lines labels Feb 20, 2020
@zpeters
Copy link
Contributor

zpeters commented Oct 4, 2020

I would like to give this a go. Mind assigning it to me?

@wopian
Copy link
Collaborator Author

wopian commented Oct 4, 2020

@zpeters assigned!

@zpeters
Copy link
Contributor

zpeters commented Oct 4, 2020

Review completed. No typos found.

The only "discrepancy" I noted was on page 1298. The below exists in the code, but not on the original scan. I assume this is intentional

## [WORKAROUND] RSB 2004
SBANK= PINSUPER
## [WORKAROUND]

@zpeters
Copy link
Contributor

zpeters commented Oct 7, 2020

Going to review this one again since i made some mistakes in another review. I want to make sure i'm not missing anything

@zpeters
Copy link
Contributor

zpeters commented Oct 12, 2020

On page 1295, line 32 (of the scan) the wording in the scan is SAVE CALLER-S RETURN 2CADR. In the current code it is SAVE CALLER'S RETURN 2CARD.

I didn't see anything specifically mentioned in the instructions. Is this correct how it is or should the apostrophe be corrected to a dash?

@wopian
Copy link
Collaborator Author

wopian commented Oct 13, 2020

I didn't see anything specifically mentioned in the instructions. Is this correct how it is or should the apostrophe be corrected to a dash?

Corrected to a dash :)

@taismassaro
Copy link

hey @wopian, I see this one is still open, I'd like to take it!

@wopian wopian assigned taismassaro and unassigned zpeters Oct 18, 2021
@wopian wopian linked a pull request Oct 19, 2021 that will close this issue
Proof PHASE_TABLE_MAINTENANCE #620 #832
Open
@scottmondo
Copy link

Hi is this still available?

@taismassaro
Copy link

hey @scottmondo
I’ve got a PR open for this one since last year’s Hacktoberfest, waiting for @wopian or someone else to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taismassaro taismassaro

Labels
Good First Issue Help Wanted Size: Small 250 to 499 lines
Projects
None yet
Milestone
Luminary099
Development

Successfully merging a pull request may close this issue.

Proof PHASE_TABLE_MAINTENANCE #620 taismassaro/Apollo-11
4 participants
@zpeters @wopian @taismassaro @scottmondo