Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weight conversion tool #2

Open
3 tasks
shubham2704 opened this issue Oct 5, 2020 · 9 comments
Open
3 tasks

weight conversion tool #2

shubham2704 opened this issue Oct 5, 2020 · 9 comments
Labels
css changes in css good first issue Good for newcomers hacktoberfest hacktober fest hacktoberfest2020 hacktober fest 2020 html changes in html javascript changes in javascript

Comments

@shubham2704
Copy link
Member

shubham2704 commented Oct 5, 2020

Create a weight conversion tool in html,css and javascript.

  • Add navbar in your tool's html file. You can copy the navbar from index.html.
  • Add screenshot of your tool in, PR message and also in the folder of your tool
  • Before Making the PR Pull the latest changes that have been made to the repository

**Note: Please Don't Make Any Changes In index.html AND contributors.html **

Add this to your pr message

Title

Number of files/folder added

changes made

I have;

  • Read contibuting.md
  • Followed all the guidelines
  • updated readme.md
@shubham2704 shubham2704 added good first issue Good for newcomers hacktoberfest hacktober fest hacktoberfest2020 hacktober fest 2020 javascript changes in javascript html changes in html css changes in css labels Oct 5, 2020
@prakhar-ai
Copy link

Can I work on this issue?

@shubham2704
Copy link
Member Author

@prakhar-ai are you still working on this?

read the new guidelines:

  • Add navbar in your tool's html file. You can copy the navbar from index.html.
  • Add screenshot of your tool in, PR message and also in the folder of your tool
  • Before Making the PR Pull the latest changes that have been made to the repository

**Note: Please Don't Make Any Changes In index.html AND contributors.html **

@prakhar-ai
Copy link

@shubham2704 Yes, I'm sorry for the delay. Will be adding the pull request in a few hours.

@shubham2704
Copy link
Member Author

@prakhar-ai No problem! As our contributing guidelines have been changed so read them before and make changes accordingly before makin the pull request. ✌

@shubham2704
Copy link
Member Author

@prakhar-ai Are you still working on this issue.

@ramonborges15
Copy link
Contributor

ramonborges15 commented Oct 22, 2020

@shubham2704 can you assign it to me?

@programmerraja
Copy link
Contributor

programmerraja commented Oct 25, 2020

@shubham2704
Is this still open i completed this work sir
Can i pull my request

@shubham2704
Copy link
Member Author

@programmerraja Yes you can crete a new pull request for this issue. ✌

@ramonborges15 ramonborges15 removed their assignment Oct 26, 2020
@programmerraja
Copy link
Contributor

@shubham2704 sir can you take look my pull request #135
Just 3 days to go sir to complete hacktoberfest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css changes in css good first issue Good for newcomers hacktoberfest hacktober fest hacktoberfest2020 hacktober fest 2020 html changes in html javascript changes in javascript
Projects
None yet
Development

No branches or pull requests

4 participants