Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume conversion tool #27

Open
4 tasks
shubham2704 opened this issue Oct 7, 2020 · 7 comments
Open
4 tasks

Volume conversion tool #27

shubham2704 opened this issue Oct 7, 2020 · 7 comments
Labels
css changes in css enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktober fest hacktoberfest2020 hacktober fest 2020 help wanted Extra attention is needed html changes in html javascript changes in javascript

Comments

@shubham2704
Copy link
Member

shubham2704 commented Oct 7, 2020

Create a Volume conversion tool in html,css and javascript.

  • Add navbar in your tool's html file. You can copy the navbar from index.html.
  • Add screenshot of your tool in, PR message and also in the folder of your tool
  • Before Making the PR Pull the latest changes that have been made to the repository

**Note: Please Don't Make Any Changes In index.html AND contributors.html **

Add the below mention section to your PR message

Title

Number of files/folder added

changes made

I have;

  • Read contibuting.md
  • Followed all the guidelines
  • updated readme.md
  • add your name in the footer of your tool.html file (if you created length conversion tool then add your name to length.html
    file you created)
@shubham2704 shubham2704 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest hacktober fest hacktoberfest2020 hacktober fest 2020 javascript changes in javascript html changes in html css changes in css labels Oct 7, 2020
@astha-garhewal
Copy link
Contributor

@shubham2704 I would like to work on this issue.

@programmerraja
Copy link
Contributor

Is this still open sir ?

@shubham2704
Copy link
Member Author

@programmerraja Yes this issue is still open.

@programmerraja
Copy link
Contributor

programmerraja commented Oct 26, 2020

@shubham2704 i completed this sir i pull my request

@programmerraja
Copy link
Contributor

@shubham2704 sir can you take look my pull request #136
Just 3 days to go sir to complete hacktoberfest

@shubham2704
Copy link
Member Author

@programmerraja very sorry for the delay but we were facing some bug issues. That's why we didn't merged the new pull request.
Don't worry I will mark both of you pull request as hacktoberfest-accepted if they don't have any conflicts.

@programmerraja
Copy link
Contributor

@shubham2704 Ok sir thank you so much 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css changes in css enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktober fest hacktoberfest2020 hacktober fest 2020 help wanted Extra attention is needed html changes in html javascript changes in javascript
Projects
None yet
Development

No branches or pull requests

3 participants