Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--as-cran default results in warnings when pushing a released version #152

Open
wch opened this issue Mar 31, 2015 · 1 comment
Open

--as-cran default results in warnings when pushing a released version #152

wch opened this issue Mar 31, 2015 · 1 comment

Comments

@wch
Copy link

wch commented Mar 31, 2015

If you release a version of a package to CRAN, and then push a commit where the version number is the same as that released version, you'll get a warning. For example, after ggvis 0.4.1 was accepted on CRAN, I merged the v0.4.1-rc branch into master. The result is a warning (or error when you use warnings_are_errors: true):
https://travis-ci.org/rstudio/ggvis/builds/56582281#L1194-L1196

I think that this shouldn't trigger an error, since the code is fine. Generally I think it's desirable to use the settings enabled by --as-cran, except for this version check.

In order to enable all the --as-cran settings without actually using --as-cran, one can set the environment variables listed at the bottom of this section of R Internals. That's what we do in devtools: https://github.com/hadley/devtools/blob/a07114c/R/check.r#L126-L159

@hadley
Copy link
Contributor

hadley commented Mar 31, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants