Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social media icons are visible even if the URLs are not provided #152

Closed
roopeshsn opened this issue Oct 2, 2022 · 1 comment
Closed

Comments

@roopeshsn
Copy link

roopeshsn commented Oct 2, 2022

Describe the bug
To create a portfolio website under the "User Details" there are fields to enter the "Social Handles" URL. Though, if the links are not given for some of the social accounts the website is displaying the respective social media icon. In my case, I have given only Twitter, Linkedin, and GitHub URLs. But on the website, the Facebook and Instagram icons are also visible. Similar behavior in the footer too.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the website creation page https://www.portfolioshop.tech/
  2. Give the "Social Handles" URL which is under "User Details"
  3. Save the changes and click the "VISIT YOUR WEBSITE" button
  4. See the icons in the Hero section

Expected behavior
It only renders the icon for the URLs provided

Screenshots
portfolio_shop_social_handles

porfolio_shop_homepage

portfolio_shop_footer

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 106

Smartphone (please complete the following information):

  • Device: No response
  • OS: No response
  • Browser: No response
  • Version: No response

Additional context
No response

@ayush-tiwari26
Copy link
Collaborator

Duplicate Issue, #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants