-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Delta as diffFilter
breaks keyboard input with git add -p
in Git CMD
#1650
Comments
Same here, when I start Git Bash under Windows Terminal 1.19.10573.0. I have Delta 0.16.5 (also happens with 0.17.0) and Git Bash 2.40.1.1. However, when I run |
When I upgraded to Git 2.44.0.1, it mostly behaves the same, except if I hold ctrl and hit enter, I can get it to re-display the prompt, and sometimes a ctrl-C goes through. Also, the line number vertical bars are replaced with BTW my .gitconfig contains
|
I have also the same issue (except |
After some investigation, I'm not so sure this is a bug in |
I am not sure your problem is the same as mine, it seems like some encoding issue. Have you tried running I have this in my |
I still think we have the same problem, the main issue I have is that |
@imbrish |
Glad it helped 👍 I think the broken keyboard input is mostly a problem with Git for Windows and how it interacts with Command Prompt or Terminal. Actually, it seems it is not the input that is broken, but the output, because I am still able to go through the I have also experienced similar issues before I started to use Delta. For example, using a shell command (with Anyway, I have also tried the following in git config:
But it does not change anything, the problem is exactly the same as originally described. Only piping through @dandavison possibly you could point us where to look? What exactly does delta do differently when its output is piped and when it is not? I would imagine |
Here is the Git code that interest us: add-patch.c#L403
As I said before, |
Investigating at the source 😉 If the problem lies in matching the I wonder if this works only in Command Prompt. Have you tried |
I tried |
Hello, |
I have a somehow related issue: I experience the freeze on Versions: VSCode/VSCodium 1.89.1 (system setup) |
With the following configuration in git config:
The keyboard input does not work at all when
git ap
asks:Even
Ctrl + C
does nothing, the only way to stop is withCtrl + Z
.This happens when using
git-cmd
but not when usinggit-bash
.The keyboard works normally with either of the changes below:
This seems like some race condition. Not sure if the problem is specific to delta, but then
diff-so-fancy
works fine.Is there something else I could try to debug this?
The text was updated successfully, but these errors were encountered: