-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 test env::tests::test_env_parsing_with_pager_set_to_bat ... FAILED #1660
Comments
Hi, thanks for the issue. This is a flaky test that relies on setting environment variables (which in general does not work with Rust tests seeing as they are executed concurrently by default). It needs to be re-written, perhaps using something like https://github.com/vmx/temp-env |
IC. Thanks for answer! I will run them with |
Great! Sorry about that; we will fix it soon. |
same issue on armhf build for alpine. Will try @vt-alt's suggestion. |
One of the tests (test_env_parsing_with_pager_set_to_bat) sets an environment variable, which can be flaky with multiple threads (see dandavison/delta#1660). Work around this by running the tests with 1 thread until this is fixed upstream.
When building a
detla
package for ALT from the tag0.17.0
tests fail with:Temporary build log: https://git.altlinux.org/tasks/342942/build/100/x86_64/log
Interestingly, when I try to reproduce this on other host with the same build env it does not fail:
Both envs do not have
bat
binary. Ifbat
binary is installed the test fails anyway.ps. It looks like the test fails probabilistically. But because we have 4 build architectures, it fails with a high probability when build for all of them. Stat from different build runs:
The text was updated successfully, but these errors were encountered: