Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Kadane's algorithm in Java #221

Open
5 of 6 tasks
akshaygidwani404 opened this issue Oct 8, 2021 · 12 comments
Open
5 of 6 tasks

Implement Kadane's algorithm in Java #221

akshaygidwani404 opened this issue Oct 8, 2021 · 12 comments
Assignees
Labels
algorithm For issues related to algorithms' code and/or theory good first issue Good for newcomers hacktoberfest Welcome to people planning to contribute as a part of Hacktoberfest

Comments

@akshaygidwani404
Copy link
Contributor

akshaygidwani404 commented Oct 8, 2021

Implement Kadane's algorithm in Java

Please read the contributing guidelines in CONTRIBUTING.md

Languages claimed/implemented:

  • C
  • C++
  • Java
  • Python
  • Javascript
  • Any other language
@akshaygidwani404 akshaygidwani404 added algorithm For issues related to algorithms' code and/or theory good first issue Good for newcomers hacktoberfest Welcome to people planning to contribute as a part of Hacktoberfest labels Oct 8, 2021
@DarkSoul26
Copy link

@akshaygidwani404 I want to contribute to this problem.

@akshaygidwani404
Copy link
Contributor Author

Hey @deutranium! I have implemented Kadane's algorithm in Java following Contribution Guidelines and reference to issue #221 and made a PR #222 for the same. Kindly review it and merge it. Thanks!

@AdityaVSM
Copy link
Contributor

Hello, I would want to contribute to this repo. I can implement Kadane's algorithm in C language. Can you assign it to me?

@codelixir
Copy link
Collaborator

@AdityaVSM Hi! Yes, you can work on it.
@DarkSoul26 Hi! Yes, you can do it as long as it's in a language other than C/C++/Java/Python as the code in these languages is already done/claimed.

@akshaygidwani404 I have commented on the PR, please have a look.

@akshaygidwani404
Copy link
Contributor Author

Thank you @codelixir for your feedback. I have fixed the issue. PR #222. Kindly review it. Thanks!

@codelixir
Copy link
Collaborator

Closed #222 for java. Thanks @akshaygidwani404!

@AdityaVSM
Copy link
Contributor

AdityaVSM commented Oct 16, 2021

Hello @codelixir , @akshaygidwani404 can you check PR #230

@codelixir
Copy link
Collaborator

Closing for C. Thanks, @AdityaVSM!

@skywalker2207
Copy link
Contributor

skywalker2207 commented Oct 13, 2022

hey @codelixir please assign me the issue to solve it in javascript

@1-Sanchit-1
Copy link

@codelixir Hii , I can implement Kadane's algorithm in C++ language. Can you please assign me

@codelixir
Copy link
Collaborator

@1-Sanchit-1 it is already implemented in C++, you can do it in any language not taken up yet

@codelixir
Copy link
Collaborator

Merged #261 for JS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm For issues related to algorithms' code and/or theory good first issue Good for newcomers hacktoberfest Welcome to people planning to contribute as a part of Hacktoberfest
Projects
None yet
Development

No branches or pull requests

6 participants