Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExternalVHDLLibrary incomplete type hint #65

Open
RasmusGOlsen opened this issue Nov 30, 2023 · 0 comments
Open

ExternalVHDLLibrary incomplete type hint #65

RasmusGOlsen opened this issue Nov 30, 2023 · 0 comments

Comments

@RasmusGOlsen
Copy link

pyEDAA.ProjectModel/pyEDAA/ProjectModel/__init__.py

Line 1095 in 38aa30f

_externalVHDLLibraries: List

The type of the library is missing. It should probably be VHDLLibrary. It would also make sense to follow the pattern from the FileSet VHDL libraries and have a Dict instead of the List.

pyEDAA.ProjectModel/pyEDAA/ProjectModel/__init__.py

Line 595 in 38aa30f

_vhdlLibraries: Dict[str, 'VHDLLibrary']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RasmusGOlsen