Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Troubleshooting required checks doesn't explain skipped check behaviour with 'needs' #32065

Closed
1 task done
innomatics opened this issue Mar 13, 2024 · 4 comments · Fixed by #32064
Closed
1 task done

Troubleshooting required checks doesn't explain skipped check behaviour with 'needs' #32065

innomatics opened this issue Mar 13, 2024 · 4 comments · Fixed by #32064
Labels
content This issue or pull request belongs to the Docs Content team pull requests Content related to pull requests triage Do not begin working on this issue until triaged by the team

Comments

@innomatics
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

What part(s) of the article would you like to see updated?

The warnings about skipped checks don't explain that jobs skipped because dependent jobs in their 'needs' clause won't cause required checks to fail.

This is important because user may believe their branches are protected when they are not.

Additional information

No response
@innomatics innomatics added the content This issue or pull request belongs to the Docs Content team label Mar 13, 2024
@welcome Welcome
Copy link

welcome bot commented Mar 13, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 13, 2024
@innomatics innomatics mentioned this issue Mar 13, 2024
Merged
2 tasks
@nguyenalex836 nguyenalex836 added pull requests Content related to pull requests and removed triage Do not begin working on this issue until triaged by the team labels Mar 13, 2024
@nguyenalex836
Copy link
Contributor

@innomatics Thank you for opening an issue and linking it to your PR! ✨

@github-actions GitHub Actions
Copy link
Contributor

A stale label has been added to this issue because it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label May 21, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@nguyenalex836 nguyenalex836 reopened this May 21, 2024
@nguyenalex836 nguyenalex836 removed the stale There is no recent activity on this issue or pull request label May 21, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 21, 2024
@g9K5ZTr0

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team pull requests Content related to pull requests triage Do not begin working on this issue until triaged by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify required check for skipped jobs using 'needs' innomatics/docs
5 participants
@innomatics @g9K5ZTr0 @nguyenalex836 and others