-
Notifications
You must be signed in to change notification settings - Fork 58.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix period should be moved inside ending quotation marks #33051
Conversation
…ooting-connectivity-problems.md <!-- Thank you for contributing to this project! You must fill out the information below before we can review this pull request. By explaining why you're making a change (or linking to an issue) and what changes you've made, we can triage your pull request to the best possible team for review. --> ### Why: Closes: github#33035 <!-- If there's an existing issue for your change, please link to it above. If there's _not_ an existing issue, please open one first to make it more likely that this update will be accepted: https://github.com/github/docs/issues/new/choose. --> ### What's being changed (if available, include any code snippets, screenshots, or gifs): <!-- Let us know what you are changing. Share anything that could provide the most context. If you made changes to the `content` directory, a table will populate in a comment below with links to the preview and current production articles. --> In Markdown file line 35, I have changed `".` changed to `."` It will move the period and place it inside the quotation marks to maintain consistency with other docs and [style guide](https://docs.github.com/en/contributing/style-guide-and-content-model/style-guide) ### Check off the following: - [x] I have reviewed my changes in staging, available via the **View deployment** link in this PR's timeline (this link will be available after opening the PR). - For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the `data` directory. - [x] For content changes, I have completed the [self-review checklist](https://docs.github.com/en/contributing/collaborating-on-github-docs/self-review-checklist).
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
This comment was marked as spam.
This comment was marked as spam.
@wahyusa Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes: #33035
What's being changed (if available, include any code snippets, screenshots, or gifs):
In Markdown file line 35, I have changed
".
changed to."
It will move the period and place it inside the quotation marks to maintain consistency with other docs and style guide
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.