Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged PR should hidden time tracker? #30989

Open
yp05327 opened this issue May 16, 2024 · 2 comments
Open

Merged PR should hidden time tracker? #30989

yp05327 opened this issue May 16, 2024 · 2 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@yp05327
Copy link
Contributor

yp05327 commented May 16, 2024

Feature Description

image

As the PR is merged, there's no need to use time tracker.

Screenshots

No response

@yp05327 yp05327 added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label May 16, 2024
@kemzeb
Copy link
Contributor

kemzeb commented May 16, 2024

I would also argue that we shouldn't be able to set a due date on a merged PR since to my knowledge users would only use this feature to ensure that they code review/merge PRs in a timely manner. Not sure if it's used beyond that

@silverwind
Copy link
Member

silverwind commented May 27, 2024

I would also argue that we shouldn't be able to set a due date on a merged PR since to my knowledge users would only use this feature to ensure that they code review/merge PRs in a timely manner. Not sure if it's used beyond that

I think you are talking about a different topic, but I agree, due date on closed PR/issue makes no sense and we should hide that section.

On topic of time tracker: Not sure, maybe some users prefer to retroactively book time into a PR, thought I guess we should not encourage such practives. In fact I think we should automatically stop any active timers when a PR is merged. Maybe keep this behaviour configurable, thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

3 participants