Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data-race during testing #30999

Merged
merged 2 commits into from
May 20, 2024
Merged

Fix data-race during testing #30999

merged 2 commits into from
May 20, 2024

Conversation

wxiaoguang
Copy link
Contributor

Fix #30992

@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.22 This PR should be backported to Gitea 1.22 labels May 16, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 16, 2024
@wxiaoguang wxiaoguang mentioned this pull request May 16, 2024
Closed
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 16, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 17, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 20, 2024
@lunny lunny enabled auto-merge (squash) May 20, 2024 04:08
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 20, 2024
@lunny lunny merged commit 47accfe into go-gitea:main May 20, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 20, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 20, 2024
@wxiaoguang @GiteaBot
Fix data-race during testing (go-gitea#30999)
de42fe0 
Fix go-gitea#30992
@GiteaBot GiteaBot mentioned this pull request May 20, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 20, 2024
@wxiaoguang wxiaoguang deleted the fix-data-race branch May 20, 2024 05:40
wxiaoguang added a commit that referenced this pull request May 20, 2024
@GiteaBot @wxiaoguang
Fix data-race during testing (#30999) (#31024)
d17bfad 
Backport #30999 by wxiaoguang

Fix #30992

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 21, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d07ae65 
* giteaofficial/main:
  Don't include link of deleted branch when listing branches (go-gitea#31028)
  [skip ci] Updated translations via Crowdin
  Refactor sha1 and time-limited code (go-gitea#31023)
  Return `access_denied` error when an OAuth2 request is denied (go-gitea#30974)
  Avoid 500 panic error when uploading invalid maven package file (go-gitea#31014)
  Fix incorrect "blob excerpt" link when comparing files (go-gitea#31013)
  Fix project column title overflow (go-gitea#31011)
  Fix data-race during testing (go-gitea#30999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Data race during testing
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot