Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to data models are dead #1056

Open
1 of 2 tasks
slash-dev opened this issue Mar 31, 2022 · 0 comments
Open
1 of 2 tasks

Links to data models are dead #1056

slash-dev opened this issue Mar 31, 2022 · 0 comments

Comments

@slash-dev
Copy link

slash-dev commented Mar 31, 2022 •
edited by jzacsh

On the following pages:

Thanks!
@jzacsh jzacsh mentioned this issue Apr 7, 2022
Open
@SampathKumarAmex SampathKumarAmex mentioned this issue Apr 27, 2022
Open
jzacsh added a commit to jzacsh/dtp that referenced this issue Jun 27, 2022
@jzacsh
fixes 1/2 of google#1056, completing models refactor.
4d47769 
Models were moved in google#916 but this link was hardcoded into the public
site and not updated.
@jzacsh jzacsh mentioned this issue Jun 27, 2022
Merged
jzacsh added a commit that referenced this issue Jul 12, 2022
@jzacsh
fix public website links broken by model refactor (#1099)
a347141 
* rm spurious osx file accidentally committed.

This was probably committed because someone was working with git
installed but without a global gitignore. See
https://github.com/github/gitignore for more and advice on setting up a
"global ignore" when working with git.

* noop(cleanup) rm file dead as of c8cce65

`how-does-dtp-work.md` is the original file name of what's now
`documentation.md` and `how-does-dtp-work.md` was just never deleted.
That is: `git mv how-does-dtp-work.md documentation.md` was the
intention of c8cce65 but the old filename was left around and not
linked to by anything, so the file has been dead since then.

* fixes 1/2 of #1056, completing models refactor.

Models were moved in #916 but this link was hardcoded into the public
site and not updated.

* nitfix: be clear that this is the prod site

* hedge uncertainty wrt site-building by fixing URL everywhere

this repeats 4d47769 by hand in the generated code that jekyll _should_
maintain for us, but I'm punting that issue for another day (PR #1100 specifically)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slash-dev