Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual issues on NPT page: 2 grey, border of grey field and fonts #8656

Open
1 task
kelvinballoo opened this issue May 3, 2024 · 0 comments
Open
1 task
Assignees
Labels
Next Up Issues to prioritize for definition P2 Low priority Squad 2 (Team M) Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@kelvinballoo
Copy link
Collaborator

kelvinballoo commented May 3, 2024

Bug Description

Figma: https://www.figma.com/file/ntKPstnmguKI70A6xUJQVi/Application-Passwords?type=design&node-id=1-3267&mode=design&t=imRPtKsRHOwS6qSl-0

I spotted 3 issues:

  • The grey background has 2 types of grey but based on Figma, it's supposed to be only one.
  • There is no rounded border. It should be 8px radius.
  • The font family and size is not right. Based on figma it should be 'Google Sans Text' and 12.

Steps to reproduce

Test instructions originally from: https://docs.google.com/document/d/1PThnH5ZgpYksgOAW2xHI6ONeIaHk74mj9qm65dlE_1w/edit#heading=h.ufyp724raw20

  1. Spin up an environment, activate Site Kit
  2. To view the Authorize Application screen with the customized styling applied, use the following URL with the hostname of your WP site.
    wp-admin/authorize-application.php?app_name=GoogleServiceIntegration&app_id=123e4567-e89b-12d3-a456-426614174000&success_url=https%3A%2F%2Fpublishers.google.com%2Fsettings%2Fauthorization%2Fwordpress&sitekit=true

Screenshots

Screenshot 2024-05-03 at 20 17 48

Additional Context

  • PHP Version: 8.1
  • WP 5.6.13
  • OS: MacOS Sonoma
  • Browser: Chrome
  • Plugin Version: 1.126.0
  • Device: MacOS

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@ivonac4 ivonac4 added Next Up Issues to prioritize for definition Squad 2 (Team M) Issues for Squad 2 Type: Enhancement Improvement of an existing feature labels May 6, 2024
@hussain-t hussain-t self-assigned this May 7, 2024
@hussain-t hussain-t added the P2 Low priority label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Up Issues to prioritize for definition P2 Low priority Squad 2 (Team M) Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants