Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement partner authentication service #8686

Closed
1 task done
aaemnnosttv opened this issue May 9, 2024 · 1 comment
Closed
1 task done

Implement partner authentication service #8686

aaemnnosttv opened this issue May 9, 2024 · 1 comment
Labels
Module: Ads Google Ads module related issues P0 High priority QA: Eng Requires specialized QA by an engineer Squad 1 (Team S) Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented May 9, 2024

Feature Description

The partner services provided to the PAX app should be extended to include a new implementation for the authentication service.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The authenticationService of the PAX partner services should be implemented similar to others such that it is automatically provided to all PAX app instances

Implementation Brief

  • Update createPaxServices to define a new top-level authenticationService with its methods
    • get returning a GetResponse, specifically just the { accessToken: string } (authUser not needed)
      Return the same token used in the config for now
    • fix returning a FixResponse; this can be the same as fixBusinessInfo for now

Test Coverage

  • Add relevant coverage as for other services

QA Brief

QA:Eng

  • Verify that tests are passing and nothing else is affected. Basically this can be verified in CR/MR and probably go to approval afterwards since there is nothing much to test

Changelog entry

  • Add the partner authentication service to the PAX app.
@aaemnnosttv aaemnnosttv self-assigned this May 9, 2024
@aaemnnosttv aaemnnosttv added P0 High priority Type: Enhancement Improvement of an existing feature Module: Ads Google Ads module related issues Squad 1 (Team S) Issues for Squad 1 labels May 9, 2024
@aaemnnosttv aaemnnosttv removed their assignment May 9, 2024
@zutigrm zutigrm self-assigned this May 10, 2024
@zutigrm zutigrm added the QA: Eng Requires specialized QA by an engineer label May 10, 2024
@zutigrm zutigrm mentioned this issue May 10, 2024
18 tasks
@zutigrm zutigrm removed their assignment May 10, 2024
@zutigrm zutigrm assigned eugene-manuilov and unassigned zutigrm May 10, 2024
@eugene-manuilov eugene-manuilov removed their assignment May 10, 2024
@benbowler benbowler self-assigned this May 13, 2024
@benbowler
Copy link
Collaborator

QA:Eng Passed ✅

@benbowler benbowler removed their assignment May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Ads Google Ads module related issues P0 High priority QA: Eng Requires specialized QA by an engineer Squad 1 (Team S) Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants