Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to free game is incorrect when a "Mystery Game" is announced #117681

Closed
smarthomejunkie opened this issue May 18, 2024 · 3 comments · Fixed by #118314
Closed

Link to free game is incorrect when a "Mystery Game" is announced #117681

smarthomejunkie opened this issue May 18, 2024 · 3 comments · Fixed by #118314

Comments

@smarthomejunkie
Copy link

smarthomejunkie commented May 18, 2024

The problem

Current Behavior:
When the free games in the Epic Store only contain one game and the second game is just an announced "Mystery" game, the link to the second "Mystery" game is returned in the integration. In this case: https://store.epicgames.com/en-US/p/mystery-game-01

Expected behavior
The link to the first game will be returned in the integration. In this case: https://store.epicgames.com/en-US/p/dragon-age-inquisition-game-of-the-year-edition-2f0cbd

What version of Home Assistant Core has the issue?

core-2024.5.4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Epic Games STore

Link to integration documentation on our website

https://www.home-assistant.io/integrations/epic_games_store/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @hacf-fr, @Quentame, mind taking a look at this issue as it has been labeled with an integration (epic_games_store) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of epic_games_store can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign epic_games_store Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


epic_games_store documentation
epic_games_store source
(message by IssueLinks)

@smarthomejunkie
Copy link
Author

This is what the service returns:

calendar.epic_games_store_free_games:
  events:
    - start: "2024-05-16T15:00:00+00:00"
      end: "2024-05-23T15:00:00+00:00"
      summary: "Dragon Age: Inquisition – Game of the Year Edition"
      description: >-
        Winner of over 130 Game of the Year awards, discover the definitive
        Dragon Age: Inquisition experience. The Game of the Year Edition
        includes the critically acclaimed game, all three official add-ons -
        Jaws of Hakkon, The Descent, and Trespasser - and more.


        https://store.epicgames.com/en-US/p/mystery-game-01
        

@smarthomejunkie smarthomejunkie changed the title Link to free game is incorrect when a "Mystery Game" is anounced Link to free game is incorrect when a "Mystery Game" is announced May 19, 2024
@Quentame
Copy link
Member

Hi !
Seen that, I may check that this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants