Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on searching in commits #3564

Open
yimingwangdell opened this issue May 16, 2024 · 2 comments
Open

crash on searching in commits #3564

yimingwangdell opened this issue May 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@yimingwangdell
Copy link

Describe the bug

To Reproduce
my project is super big, which has around 140000 commits,
when use / to search a keywork in first commit message.
it stuck for a while, then crashed.

Expected behavior
improve searching speed. then no crash.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Version info:
0.41.0
2.35.3

Additional context
Add any other context about the problem here.

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.

@yimingwangdell yimingwangdell added the bug Something isn't working label May 16, 2024
@yimingwangdell yimingwangdell changed the title slow on search in commits crash on searching in commits May 16, 2024
@yimingwangdell
Copy link
Author

I am not sure if commit number is a problem because it looks only 300 commits are loaded.

@stefanhaller
Copy link
Collaborator

This is a known problem. What happens here is that normally lazygit only loads the first 300 commits, that's why it's tolerably fast even in huge repositories; however, when you scroll all the way down to the last of those 300 commits (or press > to get there quickly), lazygit loads all commits, and this currently takes so much memory that it either gets unbearably slow, or even crashes.

And the same happens when you press / to search: this also triggers loading all commits, on the assumption that you may want to search them all.

There has been some work on improving the memory consumption, see #2533. I'm planning on picking up that work again relatively soon, but I can't promise anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants