Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Confirm connection - information notif #10319

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

hassnian
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs QA check

  • @kodadot/qa-guild please review

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-05-18.at.11.25.06.mp4

CleanShot 2024-05-18 at 11 26 24@2x

@hassnian hassnian requested a review from a team as a code owner May 18, 2024 06:26
@hassnian hassnian requested review from daiagi and Jarsen136 and removed request for a team May 18, 2024 06:26
Copy link

netlify bot commented May 18, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a537edd
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/664b12acdde50a0008f5686e
😎 Deploy Preview https://deploy-preview-10319--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

components/profile/create/Modal.vue Show resolved Hide resolved
Copy link

codeclimate bot commented May 20, 2024

Code Climate has analyzed commit a537edd and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 20, 2024
@prury prury added this pull request to the merge queue May 20, 2024
Merged via the queue into kodadot:main with commit 742ccbe May 20, 2024
17 of 19 checks passed
@prury prury deleted the issue-10234 branch May 20, 2024 13:34
This was referenced Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm connection - information notif
4 participants