Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview images on /code-checker #10207

Closed
2 tasks
preschian opened this issue May 4, 2024 · 5 comments · Fixed by #10240
Closed
2 tasks

Preview images on /code-checker #10207

preschian opened this issue May 4, 2024 · 5 comments · Fixed by #10240
Assignees
@hassnian
Labels
A-drop-page issues related to drop page enhancement New feature or request

Comments

@preschian
Copy link
Member

preschian commented May 4, 2024 •
edited

The other drops so far look fine. To prevent this issue in the future, can we put an image preview with capture workers under /code-checker for now?

Originally posted by @preschian in #10144 (comment)

endpoint: https://kodacapture.vercel.app/
requirements:

  • add ten (or more) previews with captured images
  • add ten (or more) previews with canvas. to see the page performance

cc @kodadot/internal-dev

related:
@preschian preschian added enhancement New feature or request A-drop-page issues related to drop page labels May 4, 2024
@preschian preschian mentioned this issue May 4, 2024
Closed
@exezbcz
Copy link
Member

exezbcz commented May 4, 2024

I am not sure if design is needed.

here is one quick if yes

image
image

@hassnian hassnian self-assigned this May 4, 2024
@hassnian
Copy link
Contributor

hassnian commented May 6, 2024

add ten (or more) previews with captured images

@preschian for this we would need to upload the content somewhere, cloudflare pages seems a good candidate, wdyt?

@vikiival
Copy link
Member

vikiival commented May 6, 2024

add ten (or more) previews with captured images

@preschian for this we would need to upload the content somewhere, cloudflare pages seems a good candidate, wdyt?

@vikiival
Copy link
Member

vikiival commented May 6, 2024

@hassnian hassnian mentioned this issue May 6, 2024
Merged
6 tasks
@preschian
Copy link
Member Author

cloudflare pages seems a good candidate, wdyt?

I'm ok with this. If this takes longer to accomplish, maybe upload it to ipfs first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hassnian hassnian

Labels
A-drop-page issues related to drop page enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Preview images on /code-checker hassnian/nft-gallery
4 participants
@preschian @vikiival @hassnian @exezbcz