Remove giant squid from the code #10299
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Jarsen136
changed the title
Jarsen136
requested review from
vikiival and
daiagi
and removed request for
a team
It's the wrong analysis from codeclimate. Let's ignore it. |
|
tests can be ignored as well, twitter changed itself to x |
|
i'm checking the other errors |
|
getting some different errors now:
|
not sure errors is the right word here these profiles simply don't exist |
Yup. It's the expected response result with a 404 status code, so it's not a real "error". However, if we would like to make the console look more clean without showing any request 404 code, I will simply change the 404 code to 200 and return |
✅ https://github.com/kodadot/private-workers/pull/159 Deployed and also removed the error log from the console |
Thanks! I have updated them. |
|
@Jarsen136 |
#10324 It could be done first. |
prury
added
the
S-works-for-me-✅
|
@vikiival How about merging it ? |
|
Is it somehow cached? |
It's already cached but not ideal. Ideally, It needs a better fetching library with cache. Should I implement it at the current PR also? |
|
✅ Cache Handler
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. What is protestware?This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function. Consider that consuming this package my come along with functionality unrelated to its primary purpose. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
@Jarsen136 can you check socket security issues? |
The issues it reported are not from this PR. I have no idea why it's warning here. Let's ignore it for now.
package in the code: |
strange indeed, thank you checking! |
|
Code Climate has analyzed commit f757d47 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
identitysetting page completelyvue-queryto better manage the request cache #Better data-fetching library for nuxt #10329/profiles?ids=string[]cache profile calls #10323Did your issue had any of the "$" label on it?
Screenshot 📸