Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection shows no name and thumbnails don't get updated #10287

Open
prury opened this issue May 13, 2024 · 7 comments
Open

Collection shows no name and thumbnails don't get updated #10287

prury opened this issue May 13, 2024 · 7 comments
Assignees
Labels
A-collection work being done collection view bug Something isn't working intern tasks intended for internal team p1 preventing everyone from using app

Comments

@prury
Copy link
Member

prury commented May 13, 2024

Was making some tests on canary and realized that after creating a Collection with some nfts inside, the information about the collection and its thumbnails are not being updated as shown in this video:

thumbnails on more from this collections and profile are showing the collection banner image

Gravacao.de.tela.de.13-05-2024.11.34.09.webm

https://deploy-preview-10197--koda-canary.netlify.app/ahp/collection/132

@prury prury added bug Something isn't working p1 preventing everyone from using app A-collection work being done collection view intern tasks intended for internal team labels May 13, 2024
@FG-HJ
Copy link

FG-HJ commented May 14, 2024

👋

@hassnian
Copy link
Contributor

@FG-HJ this issue is intern only

@hassnian
Copy link
Contributor

hassnian commented May 17, 2024

both are indexer issues and seem to be related to #10292 (comment)

cc @preschian

Collection

Collection Tx Meta
441 link ipfs
132 link ipfs

meta is null

CleanShot 2024-05-17 at 14 23 33@2x

CleanShot 2024-05-17 at 14 21 32@2x

NFTs

query
{
  "data": {
    "collection": {
      "id": "132",
      "name": null,
      "nfts": [
        {
          "id": "132-2",
          "metadata": "ipfs://ipfs/bafkreibyezmqkocwyvkyifmrmw7dyjhrkeg5cmaphubv6d3dvf4izbz7vu",
          "issuer": "1CBmjqJvV1ha8BPQ5JAXGEzeJBLmGHNG9gYg96eC1dnjH5W",
          "currentOwner": "1CBmjqJvV1ha8BPQ5JAXGEzeJBLmGHNG9gYg96eC1dnjH5W",
          "blockNumber": "6249162",
          "burned": false,
          "updatedAt": "2024-05-13T14:30:30.000000Z",
          "__typename": "NFTEntity",
          "name": "Koda Testing Collection 3",
          "sn": "2",
          "price": "0",
          "collection": {
            "id": "132",
            "name": null,
            "__typename": "CollectionEntity"
          },
          "meta": {
            "id": "ipfs://ipfs/bafkreige7rczfhgtq66bgjkpfcir5lebnlnt3vyeqyzjwgzgrd3jdkjwbi",
            "image": "ipfs://ipfs/bafkreifdndviy2vmyljtic6coqfypcwaaw6yhmzolkny7gcyhpbradnf2u",
            "animationUrl": null,
            "name": "Koda Testing Collection 3",
            "description": "Do not buy anything from this collection, is to test purposes only.",
            "__typename": "MetadataEntity"
          }
        }
      ],
      "__typename": "CollectionEntity"
    }
  }
}

nft's meta value is returning collection's meta

nft metadata

http://image-beta.w.kodadot.xyz/ipfs/bafkreibyezmqkocwyvkyifmrmw7dyjhrkeg5cmaphubv6d3dvf4izbz7vu

{
  "name": "PC Translucent Case",
  "description": "",
  "image": "ipfs://ipfs/bafybeib2cx7qkxtqj4ile2sdsynmgqyzk2v6mh7o5tbw356skqsw76vpiq",
  "animation_url": "",
  "attributes": [],
  "external_url": "https://kodadot.xyz",
  "type": "image/jpeg"
}

CleanShot 2024-05-17 at 14 27 53@2x

@vikiival
Copy link
Member

Cc @preschian

@preschian
Copy link
Member

Let me try. The fix should be similar to this: https://github.com/kodadot/stick/pull/265/files

The problem was that I was not sure how to test it. Because I can't develop specific block ranges in the indexer. Meanwhile, indexing all blocks takes a lot of time unless there is another alternative. Related: kodadot/stick#266. Does anyone have another tip for checking the log only on specific block ranges? @kodadot/internal-dev

@preschian
Copy link
Member

Here is some log because of timeout:

timeout errors

Screenshot 2024-05-17 at 18 42 12

Based on the logs, the indexer currently hits the rmrk and infura gateways (ref: https://github.com/kodadot/stick/blob/04f4b877765c61c26e8532fea94bed384c165bdf/src/mappings/utils/metadata.ts#L19). It would be better to hit image workers instead.

@vikiival
Copy link
Member

. It would be better to hit image workers instead.

took one line to fix
kodadot/stick#276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-collection work being done collection view bug Something isn't working intern tasks intended for internal team p1 preventing everyone from using app
Projects
None yet
Development

No branches or pull requests

5 participants