Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great scrollbar issue #9067

Open
Tracked by #9153
exezbcz opened this issue Jan 20, 2024 · 13 comments · May be fixed by #9802
Open
Tracked by #9153

Great scrollbar issue #9067

exezbcz opened this issue Jan 20, 2024 · 13 comments · May be fixed by #9802
Labels
A-mobile A-modal issues related to modals p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@exezbcz
Copy link
Member

exezbcz commented Jan 20, 2024

even more and more recordings have these funny scrollbar behaviors, mainly on mobile
image

telegram-cloud-photo-size-4-5857318700426838158-y

let's make it consistent

Desktop

question: can the modal cover navbar or it is still our limitation?

  • if not, lets make it max 90% viewport height
    • if the modal does not even fit into that, it scrolls

how it should scroll?

like this:
image

Mobile

  • to avoid scroll, enable full width modals
  • if its still bigger, its scrolls with the same as on desktop

you can try this prototype: https://www.figma.com/proto/JXNtryaNYhY0XJNArzvPQx/Handoff?page-id=1157%3A17072&type=design&node-id=7343-31511&viewport=-316%2C-652%2C0.75&t=pocpMoCHcd6EJ9wU-1&scaling=min-zoom&starting-point-node-id=1159%3A17314&mode=design

its listing modal

@exezbcz exezbcz added UX first Improvement for UX p2 core functionality, or is affecting 60% of app A-mobile A-modal issues related to modals labels Jan 20, 2024
@exezbcz
Copy link
Member Author

exezbcz commented Jan 21, 2024

side note, probably caused by
image

  • either first or the third option

@prachi00
Copy link
Member

👋

@kodabot
Copy link
Collaborator

kodabot commented Jan 26, 2024

ASSIGNED - @prachi00 🔒 LOCKED -> Saturday, January 27th 2024, 18:47:28 UTC -> 36 hours

@kodabot
Copy link
Collaborator

kodabot commented Jan 27, 2024

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

@pbkompasz
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Feb 2, 2024

ASSIGNED - @pbkompasz 🔒 LOCKED -> Saturday, February 3rd 2024, 09:21:23 UTC -> 24 hours

@pbkompasz
Copy link
Contributor

For the cart I think we can leave the purchase and total button fixed at the bottom.
Screencast from 02.02.2024 12:17:36.webm
However for the purchase modal the heading+connected wallet+everything at the bottom would take up too much space. I think the whole think should scroll and we should add an ‘arrow-down’ icon in the bottom right corner to notify the user that there is an action button at the bottom.
@exezbcz Is this ok or do you have any other ideas?

@kodabot
Copy link
Collaborator

kodabot commented Feb 3, 2024

ASSIGNMENT EXPIRED - @pbkompasz has been unassigned.

@exezbcz
Copy link
Member Author

exezbcz commented Feb 3, 2024

For the cart I think we can leave the purchase and total button fixed at the bottom.
Screencast from 02.02.2024 12:17:36.webm

yup this is fine, thanks!

I think the whole think should scroll

even with the top heading or?
image

i am tbh still not sure what would be the ideal solution for this, maybe making the default height of the modals bigger and add scroll to this part
image

  • but then for example listing modal looks bad

@exezbcz
Copy link
Member Author

exezbcz commented Mar 5, 2024

up for grabs

maybe @hassnian can pickup? 👀

@hassnian
Copy link
Contributor

hassnian commented Mar 8, 2024

👋

@kodabot
Copy link
Collaborator

kodabot commented Mar 8, 2024

ASSIGNED - @hassnian 🔒 LOCKED -> Saturday, March 9th 2024, 21:03:03 UTC -> 36 hours

@kodabot
Copy link
Collaborator

kodabot commented Mar 9, 2024

ASSIGNMENT EXPIRED - @hassnian has been unassigned.

@hassnian hassnian linked a pull request Mar 18, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mobile A-modal issues related to modals p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
5 participants