Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check - make CRAN ready #18

Open
leppott opened this issue May 11, 2018 · 3 comments
Open

Check - make CRAN ready #18

leppott opened this issue May 11, 2018 · 3 comments

Comments

@leppott
Copy link
Owner

leppott commented May 11, 2018

Run Check and make the package CRAN ready.

@leppott
Copy link
Owner Author

leppott commented May 11, 2018

Will have to cut down on file size. Extdata is 23.5 MB.

Several other things to fix but shouldn't affect functionality of the package at this time.

@leppott
Copy link
Owner Author

leppott commented Jul 31, 2018

R CMD check results
1 error | 4 warnings | 5 notes

v1.0.2.9005 (2017-07-31)

checking for portable file names ... WARNING
Found the following files with non-portable file names:
data-raw/December 2016 - Salt Results - Final.xlsx
inst/extdata/BIBI 1998 (Stribling et al.) (ea-99-6).pdf
inst/extdata/MBSS Install Guide.pdf
inst/extdata/PHI Worksheet_from MP (Erik20170329).xls
inst/extdata/Paul et al. 2003_MBSS (ea-03-4_phi).pdf
inst/extdata/Southerland et al_2005 (MBSS_new_ibi) (ea-05-13).pdf

checking for missing documentation entries ... WARNING
Undocumented code objects:
'metric.values.algae' 'metric.values.bugs' 'metric.values.fish'
All user-level objects in a package should have documentation entries.
See chapter 'Writing R documentation files' in the 'Writing R
Extensions' manual.

checking for unstated dependencies in examples ... WARNING
Warning: parse error in file 'MBSStools-Ex.R':
16: unexpected ','
29: #write.table(flow.sample,paste0("SumFlow",myYear,"_",datetime,".tab"),
30: row.names=FALSE,
^

checking data for non-ASCII characters ... WARNING
Warning: found non-ASCII strings
'ATKI-102-X-2016 ' in object 'taxa_bugs_family'
'ATKI-102-X-2016 ' in object 'taxa_bugs_genus'

@leppott
Copy link
Owner Author

leppott commented Jan 11, 2021

Addressing CMD check issues with help of CodeFactor, codecov, lintr, and goodpractices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant