Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric.scores - Family BIBI incorrect upper end of scale #45

Open
leppott opened this issue Apr 5, 2024 · 2 comments
Open

metric.scores - Family BIBI incorrect upper end of scale #45

leppott opened this issue Apr 5, 2024 · 2 comments
Labels

Comments

@leppott
Copy link
Owner

leppott commented Apr 5, 2024

Describe the bug
Unlike genus BIBI the Family BIBI uses "greater than" instead of "greater than or equal" for its thresholds. The values entered in to the rules table did not adjust for this and values at the upper threshold are being scored a "5" instead of a "3".

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Metric thresholds from report.

image

Additional context
Revised threshold values provided by MBSS staff.

image

Unlike the BioMonTools package that uses an Excel file the extdata folder the MBSStools package has the values in the package as an internal data file. Revise the .tab file and process data script in "data-raw" folder.

@leppott
Copy link
Owner Author

leppott commented Apr 5, 2024

Added language to function help to reinforce that values used in the function are different from those in the published report due to the different mathematical operator used in the function.

image

code for scroing:

image

leppott added a commit that referenced this issue Apr 5, 2024
- fix: Revise family BIBI scoring thresholds, Issue \#45
- test: Added test for extra digits for scoring thresholds
- refactor: Update vignette for IBI calculations, Issue \#45
  - StringAsFactors default now FALSE so don’t have to remove in
    Vignette
@leppott
Copy link
Owner Author

leppott commented Apr 8, 2024

Need to QC then can close.

image

@leppott leppott added the QC label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant