Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotations in pdf don't work when crossing a page boundary #11294

Open
1 of 2 tasks
Dieterbe opened this issue May 6, 2024 · 0 comments
Open
1 of 2 tasks

annotations in pdf don't work when crossing a page boundary #11294

Dieterbe opened this issue May 6, 2024 · 0 comments
Labels
pdf :type/enhancement Enhancement to product. Does not affect the overall basic use.

Comments

@Dieterbe
Copy link

Dieterbe commented May 6, 2024

Search first

  • I searched and no similar issues were found

What Happened?

i have a pdf document of about 70 pages.
when i make text annotations (highlights) it generally works well, as long as the text is within the same page.
when i make a text annotation that covers text from the end of one page, to the beginning of the next, the software gets confused. it never highlights the part of the text on the second page. on the first page, sometimes it highlights all the text on the first page instead.

Reproduce the Bug

  1. download https://cartographicperspectives.org/index.php/journal/article/view/cp43-complete-issue/pdf (this is just a random pdf file i found online for testing, there's probably many other examples we can use)
  2. import in logseq and open it
  3. find some text between two pages and try to highlight it, like on page 4 to page 5 for example

logseq-1
5. click a color to highlight. note that it highlighted the wrong text!
6.
logseq-2

Expected Behavior

No response

Screenshots

No response

Desktop or Mobile Platform Information

logseq 0.10.7 on arch linux

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.

  • I'm willing to submit a PR (Thank you!)
@andelf andelf added :type/enhancement Enhancement to product. Does not affect the overall basic use. pdf labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pdf :type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
None yet
Development

No branches or pull requests

2 participants