Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Restore Snapshot spec - Snapshot equality testing is unstable due to deserialization differences #30

Open
todo bot opened this issue Jun 19, 2020 · 0 comments
Labels
enhancement New feature or request ruby Pull requests that update Ruby code tests todo 🗒️

Comments

@todo
Copy link

todo bot commented Jun 19, 2020

# @todo there needs to be better equality checking for snapshots.
# When restored, apparently sometimes things get out of order even
# though the data *inside* each record is fine.
if file.ends_with?('.json') && new_hash != ref_hash


This issue was generated by todo based on a todo comment in bffd4d3. It's been assigned to @mrysav because they committed the code.
@todo todo bot added the todo 🗒️ label Jun 19, 2020
@todo todo bot assigned mrysav Jun 19, 2020
@mrysav mrysav added enhancement New feature or request tests labels Sep 20, 2020
@mrysav mrysav changed the title there needs to be better equality checking for snapshots. Improve Restore Snapshot spec - Snapshot equality testing is unstable due to deserialization differences Sep 20, 2020
@mrysav mrysav removed their assignment Sep 21, 2020
@mrysav mrysav added the ruby Pull requests that update Ruby code label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ruby Pull requests that update Ruby code tests todo 🗒️
Projects
None yet
Development

No branches or pull requests

1 participant