Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sex- and/or gender-respecting images for People #65

Open
mrysav opened this issue Sep 23, 2021 · 2 comments
Open

Sex- and/or gender-respecting images for People #65

mrysav opened this issue Sep 23, 2021 · 2 comments
Assignees
Labels
good first issue Good for newcomers ruby Pull requests that update Ruby code small-sized!

Comments

@mrysav
Copy link
Owner

mrysav commented Sep 23, 2021

Currently, when rendering a family, People without an associated image of them display a silhouette of Lincoln. As much as some would love to claim a presidential connection, this is really just a placeholder. It would be nice if this image was more dynamic and changed depending on the sex/gender value of the Person.

family_tree

Acceptance Criteria

1. Create new images

There should be, at minimum, three images:

  1. One image depicting a person with gender and sex of "male"
  2. One image depicting a person with gender and sex of "female"
  3. One image depicting a generic, genderless person for unknown/other gender/sex combinations

Optionally, you can provide images for other gender/sex combos.

In general, the design of the images should be pretty much like the existing image - just a silhouette on a plain or gradient background. @mrysav has the final say in whether or not the images will be used, but I promise I won't be picky.

If you pull images from the Internet, that is fine, but images MUST have the proper license or be in the public domain. If you pull an image from the Internet, please just link it in the issue here so I can verify that we can use it.

2. Display the correct image in the correct context

Images should only be displayed for people objects without an associated photo. Currently this logic lives in a partial.

You can keep the logic in the partial, but if you're an experienced Rails-ist you can introduce ViewComponents and make one for this.

3. (Optional) Add a test

There are currently no tests that can test the UI, so you do not have to add one. But I would love it if you did!

@mrysav mrysav added good first issue Good for newcomers hacktoberfest ruby Pull requests that update Ruby code small-sized! labels Sep 23, 2021
@chethanagopinath
Copy link
Contributor

Been a while since I worked on Ruby stuff, but I would definitely love to take a crack at this if that's okay :)

@mrysav
Copy link
Owner Author

mrysav commented Oct 2, 2021

@chethanagopinath I would be happy to work with you on an issue again! 😃 I've assigned the issue to you.

You can check out CONTRIBUTING.md to get started - the development flow has changed a little bit since last year, but hopefully for the better! If you have any questions about the project or getting setup, let me know. Finally, if you want to split the work into multiple PRs in order to qualify for the Hacktoberfest t-shirt, as long as they are independently reviewable, I am OK with that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ruby Pull requests that update Ruby code small-sized!
Projects
None yet
Development

No branches or pull requests

2 participants