Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing a test step #157

Open
jrock2004 opened this issue Sep 26, 2020 · 4 comments
Open

Writing a test step #157

jrock2004 opened this issue Sep 26, 2020 · 4 comments

Comments

@jrock2004
Copy link

jrock2004 commented Sep 26, 2020

Whats your thought on writing a test step which checks that certain things are installed and in the right place?

testInstall() {
  if test ! "$(command -v brew)"; then
    echo "Brew is not installed"
    exit 1
  fi
}
@nicknisi
Copy link
Owner

I like that and have a few checks around, but for some of the bigger things like brew, it's assuming the install script has been run which does install those. Could you give an example?

@jrock2004
Copy link
Author

I guess where I was coming from was that, sometimes install something fails but the install continues. I have had issues where python is not installed or something else is missing in the path

@nicknisi
Copy link
Owner

Ooh, yeah! I've been thinking about the idea of a health check script, similar to the :checkhealth command in neovim.

@nicknisi nicknisi mentioned this issue Nov 6, 2020
5 tasks
@nicknisi
Copy link
Owner

nicknisi commented Nov 6, 2020

@jrock2004 I added a start to a script like this over at #160. Let me know what you think and if you can think of other things that might be worth checking in such a script. Thanks again for the idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants