Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edalize/flows/edaflow.py # Yeah, I know. It's just a temporary hack #431

Open
rivos-pgr opened this issue May 1, 2024 · 1 comment
Open

Comments

@rivos-pgr
Copy link

class Edaflow(object):
...

def configure_tools(self, graph):
    def merge_edam(a, b):
        # Yeah, I know. It's just a temporary hack
        return b

It's a temporary hack, but what is it supposed to do? A better comment would help developers to fill in the blanks here.

@olofk
Copy link
Owner

olofk commented Jun 10, 2024

Good question. The idea is that since this is a DAG, a node can have inputs from several different tools, in which case their EDAM descriptions need to be merged. This hasn't happened in practice yet, which is why we're taking the easy way out for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants