Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ehrQL dataset definitions that are outside of the core ehrQL documentation #1373

Open
StevenMaude opened this issue Nov 7, 2023 · 0 comments

Comments

@StevenMaude
Copy link
Contributor

StevenMaude commented Nov 7, 2023

We now test dataset definitions in the ehrQL documentation that are:

  • code blocks labelled with ehrql in the ehrQL repository's Markdown source files inside docs/
  • Python files in the ehrQL repository's docs/ directory

We don't do this in the rest of the documentation. For example, the Getting Started guide now has an ehrQL dataset definition which is not regularly tested.

This is fine for now, because there are not many dataset definitions. But we may wish to in future, particularly if there are a few of these.

The same code could probably be used as in opensafely-core/ehrql#1648, ideally reusing the test code in-place and running against this repository's docs/ directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant