Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegExp for semantic versions. #12

Open
Paebbels opened this issue Dec 4, 2021 · 1 comment
Open

RegExp for semantic versions. #12

Paebbels opened this issue Dec 4, 2021 · 1 comment
Labels
Enhancement New feature or request Versioning
Milestone

Comments

@Paebbels
Copy link
Member

Paebbels commented Dec 4, 2021

Might be added to pyTooling.Version.SemVersion, because it can be useful in that package as well. However, I don't think it's worth making Tip dependent on pyTooling.Version just for this line. This is in fact copied from https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string as-is.

A possible enhancement to Tip is to build a container image in a separated workflow. Then, Tip itself would not need to install the dependencies at runtime; it would consume a ready-to-use ghcr.io/pyTooling/Tip container. In that context, having additional dependencies would be less harmful (not at all). Moreover, if we did that, we might add a proper CLI to Tip, through pyAttributes.

Originally posted by @umarcor in pyTooling/Actions#10 (comment)

@umarcor
Copy link
Member

umarcor commented Dec 24, 2021

FTR, tip was renamed to releaser, and it is now based on a container. See https://github.com/pyTooling/Actions/tree/main/releaser.

@Paebbels Paebbels added the Enhancement New feature or request label Jan 1, 2024
@Paebbels Paebbels added this to the v6.0.0 milestone Jan 1, 2024
@Paebbels Paebbels modified the milestones: v6.0.0, v6.1.0 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Versioning
Projects
None yet
Development

No branches or pull requests

2 participants