[NEW] dynamically list test files #13219
Comments
|
@dev-jonghoonpark thanks, your contributions are welcome. |
sundb
added a commit
that referenced
this issue
May 30, 2024
**Related issue** #13219 **Motivation** Currently we have to manually update the all_tests variable when introducing new test files. **Modification** I have modified it to list test files dynamically, but instead of modifying it to add all test files, I have modified it to only add only test files from the following 4 paths - unit - unit/type - unit/cluster - integration so that it doesn't deviate too much from what we already do **Result** - dynamically list test files to all_tests variable - close issue #13219 **Additional information** - removed `list-common.tcl` file and added `generate_largevalue_test_array` proc in `util.tcl`. because `list-common.tcl` is not a test file - There is an order dependency. So I added a code to the "Is a ziplist encoded Hash promoted on big payload?" test that resets hash-max-listpack-value to the default (64). --------- Signed-off-by: jonghoonpark <dev@jonghoonpark.com> Co-authored-by: debing.sun <debing.sun@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem/use-case that the feature addresses
Currently the test_helper.tcl file maintains a list of test file names all_tests and iterates throught the list to execute all tests. the all_tests variable needs to be manually updated when new test files are introduced.
Description of the feature
dynamically list test files
Alternatives you've considered
Currently, the all_tests variable contains tests from four paths.
So, we'll implement files in these four paths to be dynamically added to the all_tests variable.
Additional information
I've already merged this feature into the valkey project, which is a fork of redis.
valkey-io/valkey#313
I would like to merge it into redis as well, if it is allowed.
The text was updated successfully, but these errors were encountered: