Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT create a specific scorer base class for curve metrics #28941

Open
glemaitre opened this issue May 3, 2024 · 0 comments
Open

MAINT create a specific scorer base class for curve metrics #28941

glemaitre opened this issue May 3, 2024 · 0 comments
Labels
Hard Hard level of difficulty module:metrics

Comments

@glemaitre
Copy link
Member

roc_curve and precision_recall_curve are not usual score metric since they return array of two metrics parametrized by an array of threshold. If used with make_scorer, these methods would be passed to _Scorer class. However, this is an abuse of this class since it is expected to only return a scalar.

We should therefore create another base class specifically for these curve score metrics. A specific use case where these metrics will be used is internally to TunedThresholdClassifierCV: #26120

The design of such _CurveScorer should allow to simplify the internal design and we should have stronger tests as well. make_scorer should call this class as well.

@github-actions github-actions bot added the Needs Triage Issue requires triage label May 3, 2024
@adrinjalali adrinjalali added Hard Hard level of difficulty module:metrics and removed Needs Triage Issue requires triage labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hard Hard level of difficulty module:metrics
Projects
Development

No branches or pull requests

2 participants