Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages to winget #43

Open
pomazanbohdan opened this issue Jul 6, 2022 · 9 comments
Open

Add packages to winget #43

pomazanbohdan opened this issue Jul 6, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@pomazanbohdan
Copy link

https://winget.run/

@thebookisclosed thebookisclosed added the enhancement New feature or request label Oct 16, 2022
@TheBossMagnus
Copy link

Winget's feature of .zip install is only in beta and for a limited number of programs.
They don't accept any .zip program for now

@eabase
Copy link

eabase commented Dec 19, 2022

It should be straight forward to create a winget-pkg YAML and upload to that repo.

@thebookisclosed
Copy link
Owner

Unless things have changed recently, creating packages for WinGet would introduce the need to create some sort of ViVe installer bundle like @TheBossMagnus's reply hints at. (which I don't like the idea of) It's supposed to be a simple portable app with no extra setup steps.

@eabase
Copy link

eabase commented Jan 22, 2023

You don't need any zip, you just need to either ensure the exe is compiled standalone with library dependencies already included, or using a normal exe packaging tool. Like I said, this should be trivial, but if you're too lazy to google, I can't be of any help.

@thebookisclosed
Copy link
Owner

thebookisclosed commented Jan 23, 2023 via email

@pomazanbohdan
Copy link
Author

https://github.com/microsoft/winget-cli/releases

Support installing .zip files

@sitiom
Copy link

sitiom commented Jan 26, 2023

A PR is already underway:

There is an issue, however, related to symlinks. microsoft/winget-pkgs#92418 (comment):

In a VM, it installed successfully, and ran with no arguments. But both the /query and /enable arguments gave the same error:

PS C:\> C:\Users\user\AppData\Local\Microsoft\WinGet\Links\vivetool.exe /query
ViVeTool v0.3.2 - Windows feature configuration tool


Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'Albacore.ViVe, Version=2022.6.27.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.
   at Albacore.ViVeTool.Program.ProcessArgs(String[] args)
   at Albacore.ViVeTool.Program.Main(String[] args)

Is there a missing dependency?

microsoft/winget-pkgs#92418 (comment):

I guess it is the Albacore.ViVe.dll file in the same directory. I manually copied the remaining files to the Links folder and it works fine now.

@thebookisclosed Can you fix it so that it would try to find the DLL in the actual directory rather than the symlink directory?

@thebookisclosed
Copy link
Owner

ViVeTool makes no changes to how the library gets located, I don't think there is anything to fix on my end.
The PR was made without any sort of approval from my side, the manifest is most likely not well formed to make ViVe work correctly.

@sitiom
Copy link

sitiom commented Jan 27, 2023

The PR was made without any sort of approval from my side, the manifest is most likely not well formed to make ViVe work correctly.

No, it's most likely how Winget symlinks the executable that makes it the problem. The Scoop manifest works perfectly as it uses a shim. The manifest is not well formed, and there was no ill intention in making the PR. I wish you didn't ask it to get closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants