Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor_boot v4 vendor_ramdisk_table, multi-ramdisk and bootconfig support #6460

Open
osm0sis opened this issue Dec 23, 2022 · 5 comments · May be fixed by #6620
Open

vendor_boot v4 vendor_ramdisk_table, multi-ramdisk and bootconfig support #6460

osm0sis opened this issue Dec 23, 2022 · 5 comments · May be fixed by #6620
Labels
core This issue is related to Magisk Core enhancement New feature request

Comments

@osm0sis
Copy link
Collaborator

osm0sis commented Dec 23, 2022 •
edited

Device: All vendor_boot_img_hdr_v4+
Android version: All Android 12+ (from launch)
Magisk version name: a468fd9
Magisk version code: 25205

For complete vendor_boot v4 support, proper multi-ramdisk table/unpack/repack and bootconfig support is needed.

bootconfig is basically another cmdline with no size limit, and vendor_ramdisk_table needs to be parsed and updated for any potential splitting and edits of the vendor_boot v4 monolithic multi-ramdisk.
@osm0sis osm0sis added enhancement New feature request confirmed Issue confirmed to exist and the reason is known labels Dec 23, 2022
@osm0sis osm0sis mentioned this issue Dec 23, 2022
Closed
@osm0sis osm0sis changed the title vendor_boot v4 vendor_ramdisk_table and bootconfig support vendor_boot v4 vendor_ramdisk_table, multi-ramdisk and bootconfig support Dec 23, 2022
@yujincheng08
Copy link
Collaborator

in fact, @topjohnwu has privately stated that there wont be support for vendor boot repack.

@osm0sis
Copy link
Collaborator Author

osm0sis commented Dec 24, 2022 •
edited

That's disappointing to hear, but the request should still stand, as it's now needed for custom recovery installation and custom kernel vendor_boot dlkm changes.

Perhaps someone other than @topjohnwu will have the time and ability to implement it at some point.

@vvb2060 vvb2060 removed the confirmed Issue confirmed to exist and the reason is known label Dec 25, 2022
@yujincheng08
Copy link
Collaborator

custom recovery installation and custom kernel vendor_boot dlkm changes

Looks like there's nothing about Magisk. @topjohnwu, @vvb2060, and I won't support it. Let's assign it to you.

@osm0sis osm0sis removed their assignment Dec 25, 2022
@osm0sis
Copy link
Collaborator Author

osm0sis commented Dec 25, 2022 •
edited

Stop being passive aggressive. Features have been added solely for custom kernel in the past. This will remain open as a feature request for magiskboot from the custom recovery and kernel community for some other dev in the future who has the time and ability, as I clearly already said.

@nilz3000
Copy link

PR for this issue is out. Currently it doesn't support adding or removing ramdisk fragments.

@nilz3000 nilz3000 linked a pull request Feb 20, 2023 that will close this issue
Open
@yujincheng08 yujincheng08 added the core This issue is related to Magisk Core label Mar 2, 2023
@yujincheng08 yujincheng08 linked a pull request Mar 2, 2023 that will close this issue
magiskboot: add basic support for vendor_boot v4 #6620
Open
Repository owner deleted a comment from behomonth Mar 20, 2023
Repository owner deleted a comment from Yaf532 Nov 12, 2023
Repository owner deleted a comment from Yaf532 Nov 12, 2023
Repository owner locked as spam and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
core This issue is related to Magisk Core enhancement New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

magiskboot: add basic support for vendor_boot v4 nilz3000/Magisk
4 participants
@osm0sis @yujincheng08 @vvb2060 @nilz3000