Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superuser request unable to be operated on Android11+ with a screen reader because the tapjacking protection toggle is not available anymore #7290

Open
CiprianDinca9 opened this issue Sep 2, 2023 · 6 comments
Labels
enhancement New feature request

Comments

@CiprianDinca9
Copy link

Device:Samsung Galaxy S10+ on OneUI5.1 port ROM, but it happens to any device. This is a general bug
Android version:Since the tapjacking protection toggle isn't available in Magisk's settings
Magisk version name:I am using de00f1d, but this happens since long ago. Very long ago
Magisk version code:26202

When using any screen readers in this case, the superuser request is unable to be operated. To us, it shows like a window with no elements. To work around this restriction, this screen reader can help, but you need to pay for it and use it's OCR. https://github.com/nirenr/jieshuo
But many don't have money to pay to use the OCR or don't want to. OCR needs internet and when there's none, then there's a problem as it won't work. The other problem with this workaround is that sometimes it won't click and you need to scan multiple times and the time might expire if their OCR engines are super used at the time or your internet is slow. The last thing is, Many people maybe wouldn't want to use Jieshuo. TalkBack is left completely out in the dark, Jieshuo free users are also left out in the dark.
Do you think you can do something so that the superuser request can be successfully operated with screen readers? Feel free to test with Talkback.
The way we were doing it is to set automatic response to grant. But that's totally insecure and I ran into some app that asked for superuser access to do stuff that's unlegit, so I finally found out how important the set to prompt is.
If you can and it's ok, please fix this!
Kind regards and many thanks! I'm looking further to discussing this with you if you need anything else.

@CiprianDinca9
Copy link
Author

CiprianDinca9 commented Sep 2, 2023

I have updated and am still updating builds on Canary. I have switched to 26203 as well. Let me know when the problem is worked around. Kind regards!

@simsimient1

This comment was marked as abuse.

@CiprianDinca9

This comment was marked as off-topic.

@yujincheng08
Copy link
Collaborator

I think this is a duplicate of #2125, which wants to improve talkback, and there's a WIP improvement #6725.

@CiprianDinca9
Copy link
Author

I know about that issue, but that thing is not a problem anymore and this is a completely different issue.

@CiprianDinca9
Copy link
Author

This needs nothing but the elements of the superuser dialog are visible, just like they are on Android 10 and lower with tapjacking protection off. Nothing much. The Magisk app is completely accessible now. This is the only thing that needs fixed as we need to set the auto response to prompt for now or use Jieshuo with OCR.

@osm0sis osm0sis added the enhancement New feature request label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

No branches or pull requests

4 participants