Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

su request times out when User Authentication is enabled #7770

Open
nathanlepori opened this issue Feb 7, 2024 · 10 comments · May be fixed by #7577
Open

su request times out when User Authentication is enabled #7770

nathanlepori opened this issue Feb 7, 2024 · 10 comments · May be fixed by #7577
Labels
app This issue is related to Magisk App confirmed Issue confirmed to exist and the reason is known regression Something works in previous versions but not in the current one

Comments

@nathanlepori
Copy link

Device: OnePlus Open (CPH2551)
Android version: 13
Magisk version name: 3d91a56
Magisk version code: 27001

When User Authentication is enabled su hangs for about a minute after the fingerprint read and then displays "<App name> was denied Superuser rights". If using a terminal like adb shell or Termux the message "Permission denied" is also shown when the request times out. The timeout happens regardless of the app and changing the request timeout in Magisk settings doesn't make a difference (currently set to the default 10s).
The issue happens regardless of whether there are modules installed or not, and regardless of the duration chosen when root is requested. Disabling User Authentication immediately fixes the issue.
Logs:
magisk_log_2024-02-07T15.03.07.log

@plytkachodnikowa
Copy link

Same issue here, magisk 27.0 (27000), android 12 (oxygen os 12), oneplus 7 pro, similarly, disabling user authentication fixes the issue right away.

@canyie
Copy link
Collaborator

canyie commented Feb 9, 2024

Try #7577?

@nathanlepori
Copy link
Author

Hi @canyie in my case it looks a bit different, enabling user authentication does bring up the biometrics dialog and after scanning the option gets enabled correctly. That tells me that SystemUI does support biometrics on OnePlus ROMs but please correct me if I'm wrong here. Anyway I will play around with the build you linked to see if it changes anything.
Thank you :)

@CBush88
Copy link

CBush88 commented Feb 10, 2024

OnePlus 8 user, I assume this is the issue I've been facing. The last working Magisk version for me is 26.3. 26.4 and 27 cause root requests to time out.

@aviraxp
Copy link
Contributor

aviraxp commented Feb 11, 2024

Seems only happens on oneplus roms?

@nathanlepori
Copy link
Author

Was able to build and install #7577 and indeed using "Magisk Provide" mode User Authentication works fine. I guess there's something weird going on with OnePlus' implementation of SystemUI when it comes to biometrics

@yujincheng08 yujincheng08 added confirmed Issue confirmed to exist and the reason is known app This issue is related to Magisk App regression Something works in previous versions but not in the current one labels Feb 11, 2024
@xerta555
Copy link
Contributor

Ah, glad to see nathanlepori took care to open a ticket to cover this problem
Exactly the same problem is happening on my end on my OnePlus device.
I can't say exactly which version the problem started with, as I discovered it completely by accident

@Ujj11hb
Copy link

Ujj11hb commented Apr 24, 2024

#7577

@dxkf177
Copy link

dxkf177 commented May 11, 2024

Device: OnePlus Open (CPH2551) Android version: 13 Magisk version name: 3d91a56 Magisk version code: 27001

When User Authentication is enabled su hangs for about a minute after the fingerprint read and then displays " was denied Superuser rights". If using a terminal like adb shell or Termux the message "Permission denied" is also shown when the request times out. The timeout happens regardless of the app and changing the request timeout in Magisk settings doesn't make a difference (currently set to the default 10s). The issue happens regardless of whether there are modules installed or not, and regardless of the duration chosen when root is requested. Disabling User Authentication immediately fixes the issue. Logs: magisk_log_2024-02-07T15.03.07.log

@MisterFloppy
Copy link

MisterFloppy commented May 23, 2024

Seems only happens on oneplus roms?

No, its's also happening on Xiaomi roms, I'm affected in the exactly same manner as reported by dxkf177 before! Last try was at 06:54:00. If I remember correctly, until v26 of Magisk it worked fine.

Device: Pocophone F1
Android version: 9
Magisk version name: 81658d45f7236fdbd535a6c3a06ae19bc08cb842(27002)
Magisk version code: 27002

Magisk log:
magisk.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app This issue is related to Magisk App confirmed Issue confirmed to exist and the reason is known regression Something works in previous versions but not in the current one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants